Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41d9c98f authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman
Browse files

[PATCH] i2c: Drop outdated probe/remove code in i2c-isa 



Probe and remove methods are now defined at bus level. No more need to
redefine them at driver level in i2c-isa.

This lets us get rid of these annoying messages:
Driver 'it87-isa' needs updating - please use bus_type methods

Thanks to Nicolas Mailhot for reporting the problem and testing the fix.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent be79c383

drivers/i2c/busses/i2c-isa.c

+0 −12
Original line number Diff line number Diff line
@@ -72,16 +72,6 @@ static ssize_t show_adapter_name(struct device *dev, 
}

static DEVICE_ATTR(name, S_IRUGO, show_adapter_name, NULL);



static int i2c_isa_device_probe(struct device *dev)

{

	return -ENODEV;

}



static int i2c_isa_device_remove(struct device *dev)

{

	return 0;

}





/* We implement an interface which resembles i2c_{add,del}_driver,

   but for i2c-isa drivers. We don't have to remember and handle lists
@@ -93,8 +83,6 @@ int i2c_isa_add_driver(struct i2c_driver *driver) 


	/* Add the driver to the list of i2c drivers in the driver core */

	driver->driver.bus = &i2c_bus_type;

	driver->driver.probe = i2c_isa_device_probe;

	driver->driver.remove = i2c_isa_device_remove;

	res = driver_register(&driver->driver);

	if (res)

		return res;