Commit 41bdecf1 authored Nov 11, 2009 by stephen hemminger Committed by David S. Miller Nov 11, 2009

decnet: add RTNL lock when reading address list



Add missing locking in the case of auto binding to the
default device. The address list might change while this code is looking
at the list.

Compile tested only, I am not a decnet user.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 08e9897d

net/decnet/dn_dev.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -828,13 +828,17 @@ static int dn_dev_get_first(struct net_device dev, __le16 addr)
		struct dn_dev dn_db = (struct dn_dev )dev->dn_ptr;
		struct dn_ifaddr *ifa;
		int rv = -ENODEV;

		if (dn_db == NULL)
		goto out;

		rtnl_lock();
		ifa = dn_db->ifa_list;
		if (ifa != NULL) {
		*addr = ifa->ifa_local;
		rv = 0;
		}
		rtnl_unlock();
		out:
		return rv;
		}