Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41a48d14 authored by Paul Mundt's avatar Paul Mundt Committed by Frederic Weisbecker
Browse files

x86/hw-breakpoints: Actually flush thread breakpoints in flush_thread(). 



flush_thread() tries to do a TIF_DEBUG check before calling in to
flush_thread_hw_breakpoint() (which subsequently clears the thread flag),
but for some reason, the x86 code is manually clearing TIF_DEBUG
immediately before the test, so this path will never be taken.

This kills off the erroneous clear_tsk_thread_flag() and lets
flush_thread_hw_breakpoint() actually get invoked.

Presumably folks were getting lucky with testing and the
free_thread_info() -> free_thread_xstate() path was taking care of the
flush there.

Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
Acked-by: default avatar"K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Alan Stern <stern@rowland.harvard.edu>
LKML-Reference: <20091005102306.GA7889@linux-sh.org>
Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
parent fb0459d7

arch/x86/kernel/process.c

+0 −2
Original line number Diff line number Diff line
@@ -107,8 +107,6 @@ void flush_thread(void) 
	}

#endif



	clear_tsk_thread_flag(tsk, TIF_DEBUG);



	if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG)))

		flush_thread_hw_breakpoint(tsk);

	memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array));