Commit 411c9699 authored Jun 20, 2016 by John L. Hammond Committed by Greg Kroah-Hartman Jun 20, 2016

staging/lustre/llite: correct request handling after ll_lookup_it()



In the FIFO cases of ll_atomic_open() and ll_lookup_nd() remove
spurious calls to ptlrpc_req_finished(). Explain that these cases are
unreachable in practice anyway.

Signed-off-by: John L. Hammond <john.hammond@intel.com>
Reviewed-on: http://review.whamcloud.com/17068
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7402


Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1b02bde3

drivers/staging/lustre/lustre/llite/namei.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -622,13 +622,10 @@ static int ll_atomic_open(struct inode dir, struct dentry dentry,
		if (d_really_is_positive(dentry) && it_disposition(it, DISP_OPEN_OPEN)) {
		/* Open dentry. */
		if (S_ISFIFO(d_inode(dentry)->i_mode)) {
		/* We cannot call open here as it would
		* deadlock.
		/* We cannot call open here as it might
		* deadlock. This case is unreachable in
		* practice because of OBD_CONNECT_NODEVOH.
		*/
		if (it_disposition(it, DISP_ENQ_OPEN_REF))
		ptlrpc_req_finished(
		(struct ptlrpc_request *)
		it->d.lustre.it_data);
		rc = finish_no_open(file, de);
		} else {
		file->private_data = it;