Commit 4104863f authored Jul 21, 2008 by Julia Lawall Committed by John W. Linville Jul 29, 2008

b43legacy: Release mutex in error handling code

The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
... when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Cc: stable <stable@kernel.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 80c42aff

drivers/net/wireless/b43legacy/main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3845,10 +3845,10 @@ static int b43legacy_resume(struct ssb_device *dev)
		goto out;
		}
		}
		mutex_unlock(&wl->mutex);

		b43legacydbg(wl, "Device resumed.\n");
		out:
		mutex_unlock(&wl->mutex);
		return err;
		}