Commit 408208fb authored Apr 09, 2013 by Wei Yongjun Committed by Mauro Carvalho Chehab Apr 14, 2013

[media] rc: ite-cir: fix potential double free in ite_probe()



Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 4ec16da7

drivers/media/rc/ite-cir.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1613,6 +1613,7 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
	release_region(itdev->cir_addr, itdev->params.io_region_size);		release_region(itdev->cir_addr, itdev->params.io_region_size);
	exit_unregister_device:		exit_unregister_device:
	rc_unregister_device(rdev);		rc_unregister_device(rdev);
			rdev = NULL;
	exit_free_dev_rdev:		exit_free_dev_rdev:
	rc_free_device(rdev);		rc_free_device(rdev);
	kfree(itdev);		kfree(itdev);