Commit 3ff68a6a authored Nov 13, 2008 by Mark Nelson Committed by Ingo Molnar Nov 13, 2008

genirq: __irq_set_trigger: change pr_warning to pr_debug



Commit 0c5d1eb7 (genirq: record trigger
type) caused powerpc platforms that had no set_type() function in their
struct irq_chip to spew out warnings about "No set_type function for
IRQ...". This warning isn't necessarily justified though because the
generic powerpc platform code calls set_irq_type() (which in turn calls
__irq_set_trigger) with information from the device tree to establish
the interrupt mappings, regardless of whether the PIC can actually set
a type.

A platform's irq_chip might not have a set_type function for a variety
of reasons, for example: the platform may have the type essentially
hard-coded, or as in the case for Cell interrupts are just messages
past around that have no real concept of type, or the platform
could even have a virtual PIC as on the PS3.

Signed-off-by: Mark Nelson <markn@au1.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent f131e243

kernel/irq/manage.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -365,7 +365,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
		* IRQF_TRIGGER_* but the PIC does not support multiple
		* flow-types?
		*/
		pr_warning("No set_type function for IRQ %d (%s)\n", irq,
		pr_debug("No set_type function for IRQ %d (%s)\n", irq,
		chip ? (chip->name ? : "unknown") : "unknown");
		return 0;
		}