Commit 3f86eb6b authored Dec 10, 2015 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Dec 10, 2015

perf tools: Get rid of exit_browser() from usage_with_options()



Since all of its users call before setup_browser(), there's no need to
call exit_browser() inside of the function.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449716459-23004-8-git-send-email-namhyung@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 7ecb48fd

tools/perf/util/parse-options.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -766,7 +766,6 @@ int usage_with_options_internal(const char * const *usagestr,
		void usage_with_options(const char * const *usagestr,
		const struct option *opts)
		{
		exit_browser(false);
		usage_with_options_internal(usagestr, opts, 0, NULL);
		exit(129);
		}
		@@ -776,8 +775,6 @@ void usage_with_options_msg(const char * const *usagestr,
		{
		va_list ap;

		exit_browser(false);

		va_start(ap, fmt);
		strbuf_addv(&error_buf, fmt, ap);
		va_end(ap);