Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3efa921d authored by Sachin Kamat's avatar Sachin Kamat Committed by Linus Walleij
Browse files

pinctrl: sunxi: Fix incorrect NULL check 



*map should be tested for NULL instead of map as kmalloc pointer
is assigned to it. This also fixes a potential null pointer dereference
bug later in the code.

Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Acked-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 8a9dcc3f

drivers/pinctrl/pinctrl-sunxi.c

+1 −1
Original line number Diff line number Diff line
@@ -175,7 +175,7 @@ static int sunxi_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, 
	}



	*map = kmalloc(nmaps * sizeof(struct pinctrl_map), GFP_KERNEL);

	if (!map)

	if (!*map)

		return -ENOMEM;



	of_property_for_each_string(node, "allwinner,pins", prop, group) {