Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e19ca40 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: sxgbe: remove sxgbe_config 



sxgbe_config() denies changing the base address and interrupt, and
ignores all other 'struct ifmap' members, which means that it is useless
as is, so let's remove it.

Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ca6bd4fa

drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c

+0 −35
Original line number Diff line number Diff line
@@ -1909,40 +1909,6 @@ static void sxgbe_set_rx_mode(struct net_device *dev) 
		   readl(ioaddr + SXGBE_HASH_LOW));

}



/**

 * sxgbe_config - entry point for changing configuration mode passed on by

 * ifconfig

 * @dev : pointer to the device structure

 * @map : pointer to the device mapping structure

 * Description:

 * This function is a driver entry point which gets called by the kernel

 * whenever some device configuration is changed.

 * Return value:

 * This function returns 0 if success and appropriate error otherwise.

 */

static int sxgbe_config(struct net_device *dev, struct ifmap *map)

{

	struct sxgbe_priv_data *priv = netdev_priv(dev);



	/* Can't act on a running interface */

	if (dev->flags & IFF_UP)

		return -EBUSY;



	/* Don't allow changing the I/O address */

	if (map->base_addr != (unsigned long)priv->ioaddr) {

		netdev_warn(dev, "can't change I/O address\n");

		return -EOPNOTSUPP;

	}



	/* Don't allow changing the IRQ */

	if (map->irq != priv->irq) {

		netdev_warn(dev, "not change IRQ number %d\n", priv->irq);

		return -EOPNOTSUPP;

	}



	return 0;

}



#ifdef CONFIG_NET_POLL_CONTROLLER

/**

 * sxgbe_poll_controller - entry point for polling receive by device
@@ -2004,7 +1970,6 @@ static const struct net_device_ops sxgbe_netdev_ops = { 
	.ndo_set_rx_mode	= sxgbe_set_rx_mode,

	.ndo_tx_timeout		= sxgbe_tx_timeout,

	.ndo_do_ioctl		= sxgbe_ioctl,

	.ndo_set_config		= sxgbe_config,

#ifdef CONFIG_NET_POLL_CONTROLLER

	.ndo_poll_controller	= sxgbe_poll_controller,

#endif