Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dd5ee08 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: subdev: Uninline the v4l2_subdev_init function 



The function isn't small or performance sensitive enough to be inlined.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2096a5dc

drivers/media/video/v4l2-subdev.c

+28 −13
Original line number Diff line number Diff line 
/*

 *  V4L2 subdevice support.

 * V4L2 sub-device

 *

 * Copyright (C) 2010 Nokia Corporation

 *

 * Contact: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

 *	    Sakari Ailus <sakari.ailus@iki.fi>

 *

 * This program is free software; you can redistribute it and/or modify

 *  it under the terms of the GNU General Public License as published by

 *  the Free Software Foundation.

 * it under the terms of the GNU General Public License version 2 as

 * published by the Free Software Foundation.

 *

 * This program is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -58,3 +59,17 @@ const struct v4l2_file_operations v4l2_subdev_fops = { 
	.unlocked_ioctl = subdev_ioctl,

	.release = subdev_close,

};



void v4l2_subdev_init(struct v4l2_subdev *sd, const struct v4l2_subdev_ops *ops)

{

	INIT_LIST_HEAD(&sd->list);

	BUG_ON(!ops);

	sd->ops = ops;

	sd->v4l2_dev = NULL;

	sd->flags = 0;

	sd->name[0] = '\0';

	sd->grp_id = 0;

	sd->dev_priv = NULL;

	sd->host_priv = NULL;

}

EXPORT_SYMBOL(v4l2_subdev_init);

include/media/v4l2-subdev.h

+2 −13
Original line number Diff line number Diff line
@@ -487,19 +487,8 @@ static inline void *v4l2_get_subdev_hostdata(const struct v4l2_subdev *sd) 
	return sd->host_priv;

}



static inline void v4l2_subdev_init(struct v4l2_subdev *sd,

					const struct v4l2_subdev_ops *ops)

{

	INIT_LIST_HEAD(&sd->list);

	BUG_ON(!ops);

	sd->ops = ops;

	sd->v4l2_dev = NULL;

	sd->flags = 0;

	sd->name[0] = '\0';

	sd->grp_id = 0;

	sd->dev_priv = NULL;

	sd->host_priv = NULL;

}

void v4l2_subdev_init(struct v4l2_subdev *sd,

		      const struct v4l2_subdev_ops *ops);



/* Call an ops of a v4l2_subdev, doing the right checks against

   NULL pointers.