Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d53666b authored by Alex Gartrell's avatar Alex Gartrell Committed by Simon Horman
Browse files

ipvs: Avoid null-pointer deref in debug code 



Use daddr instead of reaching into dest.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Gartrell <agartrell@fb.com>
Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
parent 7965ee93

net/netfilter/ipvs/ip_vs_xmit.c

+2 −2
Original line number Diff line number Diff line
@@ -316,7 +316,7 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, 
	if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode,

						  local))) {

		IP_VS_DBG_RL("We are crossing local and non-local addresses"

			     " daddr=%pI4\n", &dest->addr.ip);

			     " daddr=%pI4\n", &daddr);

		goto err_put;

	}
@@ -458,7 +458,7 @@ __ip_vs_get_out_rt_v6(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest, 
	if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode,

						  local))) {

		IP_VS_DBG_RL("We are crossing local and non-local addresses"

			     " daddr=%pI6\n", &dest->addr.in6);

			     " daddr=%pI6\n", daddr);

		goto err_put;

	}