Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d0882c0 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Bjorn Helgaas
Browse files

PCI / PM: Fix D3/D3cold/D4 messages printed by acpi_pci_set_power_state() 



If a PCI device is put into D3_cold by acpi_bus_set_power(),
the message printed by acpi_pci_set_power_state() says that its
power state has been changed to D4, which doesn't make sense.
In turn, if the device is put into D3_hot, the message simply
says "D3" without specifying the variant of the D3 state.

Fix this by using the pci_power_name() macro for printing the state
name instead of building it from the numeric value corresponding to
the given state directly.

Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 0d7614f0

drivers/pci/pci-acpi.c

+2 −2
Original line number Diff line number Diff line
@@ -266,8 +266,8 @@ static int acpi_pci_set_power_state(struct pci_dev *dev, pci_power_t state) 
	}



	if (!error)

		dev_printk(KERN_INFO, &dev->dev,

				"power state changed by ACPI to D%d\n", state);

		dev_info(&dev->dev, "power state changed by ACPI to %s\n",

			 pci_power_name(state));



	return error;

}