Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ce05168 authored by David Fries's avatar David Fries Committed by Dave Airlie
Browse files

drm/kms: load fbcon from drm_kms_helper 



Kconfig says fbcon is required by drm_kms_helper.  If radeon, fbcon,
and drm_kms_helper are all modules, radeon is auto loaded (by PCI id?),
drm_kms_helper is loaded because of the module dependency, but fbcon
isn't loaded leaving the console unusable.  Since fbcon is required
and there isn't an explicit module dependency, request the module
to be loaded from drm_kms_helper.

Signed-off-by: default avatarDavid Fries <david@fries.net>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 7d6aa80c

drivers/gpu/drm/drm_fb_helper.c

+21 −0
Original line number Diff line number Diff line
@@ -1533,3 +1533,24 @@ bool drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) 
}

EXPORT_SYMBOL(drm_fb_helper_hotplug_event);



/* The Kconfig DRM_KMS_HELPER selects FRAMEBUFFER_CONSOLE (if !EMBEDDED)

 * but the module doesn't depend on any fb console symbols.  At least

 * attempt to load fbcon to avoid leaving the system without a usable console.

 */

#if defined(CONFIG_FRAMEBUFFER_CONSOLE_MODULE) && !defined(CONFIG_EMBEDDED)

static int __init drm_fb_helper_modinit(void)

{

	const char *name = "fbcon";

	struct module *fbcon;



	mutex_lock(&module_mutex);

	fbcon = find_module(name);

	mutex_unlock(&module_mutex);



	if (!fbcon)

		request_module_nowait(name);

	return 0;

}



module_init(drm_fb_helper_modinit);

#endif