Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b77894b authored by Viswas G's avatar Viswas G Committed by James Bottomley
Browse files

pm80xx: Remove unnecessary phy disconnect while link error 



If the link error happens, we don't need to disconnect the phy,
which will remove the drive. Instead acknowledging the controller
and logging the error will be enough.

Signed-off-by: default avatarViswas G <Viswas.G@pmcs.com>
Reviewed-by: default avatarSuresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent 3b700e34

drivers/scsi/pm8001/pm80xx_hwi.c

+0 −12
Original line number Original line Diff line number Diff line
@@ -3176,9 +3176,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb) 
			pm8001_printk("HW_EVENT_LINK_ERR_INVALID_DWORD\n"));

			pm8001_printk("HW_EVENT_LINK_ERR_INVALID_DWORD\n"));

		pm80xx_hw_event_ack_req(pm8001_ha, 0,

		pm80xx_hw_event_ack_req(pm8001_ha, 0,

			HW_EVENT_LINK_ERR_INVALID_DWORD, port_id, phy_id, 0, 0);

			HW_EVENT_LINK_ERR_INVALID_DWORD, port_id, phy_id, 0, 0);

		sas_phy_disconnected(sas_phy);

		phy->phy_attached = 0;

		sas_ha->notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);

		break;

		break;

	case HW_EVENT_LINK_ERR_DISPARITY_ERROR:

	case HW_EVENT_LINK_ERR_DISPARITY_ERROR:

		PM8001_MSG_DBG(pm8001_ha,

		PM8001_MSG_DBG(pm8001_ha,
@@ -3186,9 +3183,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb) 
		pm80xx_hw_event_ack_req(pm8001_ha, 0,

		pm80xx_hw_event_ack_req(pm8001_ha, 0,

			HW_EVENT_LINK_ERR_DISPARITY_ERROR,

			HW_EVENT_LINK_ERR_DISPARITY_ERROR,

			port_id, phy_id, 0, 0);

			port_id, phy_id, 0, 0);

		sas_phy_disconnected(sas_phy);

		phy->phy_attached = 0;

		sas_ha->notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);

		break;

		break;

	case HW_EVENT_LINK_ERR_CODE_VIOLATION:

	case HW_EVENT_LINK_ERR_CODE_VIOLATION:

		PM8001_MSG_DBG(pm8001_ha,

		PM8001_MSG_DBG(pm8001_ha,
@@ -3196,9 +3190,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb) 
		pm80xx_hw_event_ack_req(pm8001_ha, 0,

		pm80xx_hw_event_ack_req(pm8001_ha, 0,

			HW_EVENT_LINK_ERR_CODE_VIOLATION,

			HW_EVENT_LINK_ERR_CODE_VIOLATION,

			port_id, phy_id, 0, 0);

			port_id, phy_id, 0, 0);

		sas_phy_disconnected(sas_phy);

		phy->phy_attached = 0;

		sas_ha->notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);

		break;

		break;

	case HW_EVENT_LINK_ERR_LOSS_OF_DWORD_SYNCH:

	case HW_EVENT_LINK_ERR_LOSS_OF_DWORD_SYNCH:

		PM8001_MSG_DBG(pm8001_ha, pm8001_printk(

		PM8001_MSG_DBG(pm8001_ha, pm8001_printk(
@@ -3206,9 +3197,6 @@ static int mpi_hw_event(struct pm8001_hba_info *pm8001_ha, void *piomb) 
		pm80xx_hw_event_ack_req(pm8001_ha, 0,

		pm80xx_hw_event_ack_req(pm8001_ha, 0,

			HW_EVENT_LINK_ERR_LOSS_OF_DWORD_SYNCH,

			HW_EVENT_LINK_ERR_LOSS_OF_DWORD_SYNCH,

			port_id, phy_id, 0, 0);

			port_id, phy_id, 0, 0);

		sas_phy_disconnected(sas_phy);

		phy->phy_attached = 0;

		sas_ha->notify_port_event(sas_phy, PORTE_LINK_RESET_ERR);

		break;

		break;

	case HW_EVENT_MALFUNCTION:

	case HW_EVENT_MALFUNCTION:

		PM8001_MSG_DBG(pm8001_ha,

		PM8001_MSG_DBG(pm8001_ha,