Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a7f8c34 authored by Denis Efremov's avatar Denis Efremov Committed by David S. Miller
Browse files

macvtap: rcu_dereference outside read-lock section 



rcu_dereference occurs in update section. Replacement by
rcu_dereference_protected in order to prevent lockdep
complaint.

Found by Linux Driver Verification project (linuxtesting.org)

Signed-off-by: default avatarDenis Efremov <yefremov.denis@gmail.com>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2359a476

drivers/net/macvtap.c

+2 −1
Original line number Diff line number Diff line
@@ -94,7 +94,8 @@ static int get_slot(struct macvlan_dev *vlan, struct macvtap_queue *q) 
	int i;



	for (i = 0; i < MAX_MACVTAP_QUEUES; i++) {

		if (rcu_dereference(vlan->taps[i]) == q)

		if (rcu_dereference_protected(vlan->taps[i],

					      lockdep_is_held(&macvtap_lock)) == q)

			return i;

	}