Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 394fc05b authored by Dan Carpenter's avatar Dan Carpenter Committed by Dmitry Torokhov
Browse files

Input: cyttsp4 - leak on error path in probe() 



We leak "cd" if the cd->xfer_buf allocation fails.  It was weird to
"goto error_gpio_irq" so I changed the label name.  (Label names should
reflect the label location not the goto location otherwise you get an
"all roads lead to Rome problem").

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 7c4c018a

drivers/input/touchscreen/cyttsp4_core.c

+3 −3
Original line number Diff line number Diff line
@@ -2025,7 +2025,7 @@ struct cyttsp4 *cyttsp4_probe(const struct cyttsp4_bus_ops *ops, 
	if (!cd->xfer_buf) {

		dev_err(dev, "%s: Error, kzalloc\n", __func__);

		rc = -ENOMEM;

		goto error_alloc_data;

		goto error_free_cd;

	}



	/* Initialize device info */
@@ -2049,7 +2049,7 @@ struct cyttsp4 *cyttsp4_probe(const struct cyttsp4_bus_ops *ops, 
	cd->irq = gpio_to_irq(cd->cpdata->irq_gpio);

	if (cd->irq < 0) {

		rc = -EINVAL;

		goto error_gpio_irq;

		goto error_free_cd;

	}



	dev_set_drvdata(dev, cd);
@@ -2117,7 +2117,7 @@ struct cyttsp4 *cyttsp4_probe(const struct cyttsp4_bus_ops *ops, 
	if (cd->cpdata->init)

		cd->cpdata->init(cd->cpdata, 0, dev);

	dev_set_drvdata(dev, NULL);

error_gpio_irq:

error_free_cd:

	kfree(cd);

error_alloc_data:

error_no_pdata: