Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37f9648b authored by Dan Carpenter's avatar Dan Carpenter Committed by Guenter Roeck
Browse files

hwmon: (adt7410) handle errors from adt7410_update_device() 



Smatch complains that adt7410_update_device() can return error pointers.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 983b97be

drivers/hwmon/adt7410.c

+7 −2
Original line number Diff line number Diff line
@@ -236,9 +236,14 @@ static ssize_t adt7410_show_t_hyst(struct device *dev, 
				   char *buf)

{

	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);

	struct adt7410_data *data = adt7410_update_device(dev);

	struct adt7410_data *data;

	int nr = attr->index;

	int hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000;

	int hyst;



	data = adt7410_update_device(dev);

	if (IS_ERR(data))

		return PTR_ERR(data);

	hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000;



	/*

	 * hysteresis is stored as a 4 bit offset in the device, convert it