Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3716a891 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Mark Brown
Browse files

ASoC: sun4i-codec: Enable bus clock after getting GPIO 



In the current probe function the GPIO is acquired after the codec's
bus clock is enabled. However if it fails to acquire the GPIO due to
a deferred probe, it does not disable the bus clock before bailing out.
This would result in the clock being enabled multiple times.

Move the code that enables the bus clock after the part that gets the
GPIO, maintaining a separation between resource acquisition and device
enablement in the probe function.

Signed-off-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 85915b63

sound/soc/sunxi/sun4i-codec.c

+6 −6
Original line number Diff line number Diff line
@@ -829,12 +829,6 @@ static int sun4i_codec_probe(struct platform_device *pdev) 
		return PTR_ERR(scodec->clk_module);

	}



	/* Enable the bus clock */

	if (clk_prepare_enable(scodec->clk_apb)) {

		dev_err(&pdev->dev, "Failed to enable the APB clock\n");

		return -EINVAL;

	}



	scodec->gpio_pa = devm_gpiod_get_optional(&pdev->dev, "allwinner,pa",

						  GPIOD_OUT_LOW);

	if (IS_ERR(scodec->gpio_pa)) {
@@ -844,6 +838,12 @@ static int sun4i_codec_probe(struct platform_device *pdev) 
		return ret;

	}



	/* Enable the bus clock */

	if (clk_prepare_enable(scodec->clk_apb)) {

		dev_err(&pdev->dev, "Failed to enable the APB clock\n");

		return -EINVAL;

	}



	/* DMA configuration for TX FIFO */

	scodec->playback_dma_data.addr = res->start + SUN4I_CODEC_DAC_TXDATA;

	scodec->playback_dma_data.maxburst = 4;