Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36683aab authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

i82975x_edac: Test nr_pages earlier to save a few CPU cycles 



Avoid test nr_pages twice, and initializing some data that won't
be used.

Cleanup patch only.

Reported-by: default avatarAristeu Rozanski Filho <arozansk@redhat.com>
Reviewed-by: default avatarAristeu Rozanski <arozansk@redhat.com>
Cc: Ranganathan Desikan <ravi@jetztechnologies.com>
Cc: "Arvind R." <arvino55@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 805afb69

drivers/edac/i82975x_edac.c

+3 −6
Original line number Original line Diff line number Diff line
@@ -410,6 +410,9 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci, 
			cumul_size);

			cumul_size);





		nr_pages = cumul_size - last_cumul_size;

		nr_pages = cumul_size - last_cumul_size;

		if (!nr_pages)

			continue;



		/*

		/*

		 * Initialise dram labels

		 * Initialise dram labels

		 * index values:

		 * index values:
@@ -420,9 +423,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci, 
		for (chan = 0; chan < csrow->nr_channels; chan++) {

		for (chan = 0; chan < csrow->nr_channels; chan++) {

			dimm = mci->csrows[index].channels[chan].dimm;

			dimm = mci->csrows[index].channels[chan].dimm;





			if (!nr_pages)

				continue;



			dimm->nr_pages = nr_pages / csrow->nr_channels;

			dimm->nr_pages = nr_pages / csrow->nr_channels;

			strncpy(csrow->channels[chan].dimm->label,

			strncpy(csrow->channels[chan].dimm->label,

					labels[(index >> 1) + (chan * 2)],

					labels[(index >> 1) + (chan * 2)],
@@ -433,9 +433,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci, 
			dimm->edac_mode = EDAC_SECDED; /* only supported */

			dimm->edac_mode = EDAC_SECDED; /* only supported */

		}

		}





		if (!nr_pages)

			continue;	/* not populated */



		csrow->first_page = last_cumul_size;

		csrow->first_page = last_cumul_size;

		csrow->last_page = cumul_size - 1;

		csrow->last_page = cumul_size - 1;

		last_cumul_size = cumul_size;

		last_cumul_size = cumul_size;