Commit 363e0df0 authored Jan 12, 2012 by Dan Carpenter Committed by Trond Myklebust Jan 12, 2012

nfs: check for integer overflow in decode_devicenotify_args()



On 32 bit, if n is too large then "n * sizeof(*args->devs)" could
overflow and args->devs would be smaller than expected.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 13fff2f3

fs/nfs/callback_xdr.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -305,6 +305,10 @@ __be32 decode_devicenotify_args(struct svc_rqst *rqstp,
		n = ntohl(*p++);
		if (n <= 0)
		goto out;
		if (n > ULONG_MAX / sizeof(*args->devs)) {
		status = htonl(NFS4ERR_BADXDR);
		goto out;
		}

		args->devs = kmalloc(n * sizeof(*args->devs), GFP_KERNEL);
		if (!args->devs) {