Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 361ae8cb authored by Nicolas Kaiser's avatar Nicolas Kaiser Committed by Konrad Rzeszutek Wilk
Browse files

xen: events: fix error checks in bind_*_to_irqhandler() 



Checking 'irq < 0' doesn't work when 'irq' is unsigned.

The assigned bind_evtchn_to_irq() and bind_virq_to_irq()
return int, so using int appears appropriate.

Signed-off-by: default avatarNicolas Kaiser <nikai@nikai.net>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 0ce790e7

drivers/xen/events.c

+2 −4
Original line number Diff line number Diff line
@@ -912,8 +912,7 @@ int bind_evtchn_to_irqhandler(unsigned int evtchn, 
			      unsigned long irqflags,

			      const char *devname, void *dev_id)

{

	unsigned int irq;

	int retval;

	int irq, retval;



	irq = bind_evtchn_to_irq(evtchn);

	if (irq < 0)
@@ -955,8 +954,7 @@ int bind_virq_to_irqhandler(unsigned int virq, unsigned int cpu, 
			    irq_handler_t handler,

			    unsigned long irqflags, const char *devname, void *dev_id)

{

	unsigned int irq;

	int retval;

	int irq, retval;



	irq = bind_virq_to_irq(virq, cpu);

	if (irq < 0)