Commit 360943a8 authored Jun 06, 2016 by Paul Gortmaker Committed by Linus Walleij Jun 13, 2016

pinctrl: baytrail: make it explicitly non-modular



The Kconfig currently controlling compilation of this code is:

config PINCTRL_BAYTRAIL
        bool "Intel Baytrail GPIO pin control"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_init() was already not in use in this driver, we don't
have any concerns with init ordering changes here.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 682d68b8

drivers/pinctrl/intel/pinctrl-baytrail.c

+4 −21

Original line number	Diff line number	Diff line
		@@ -15,7 +15,6 @@
		*/

		#include <linux/kernel.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/types.h>
		#include <linux/bitops.h>
		@@ -1822,17 +1821,6 @@ static int byt_pinctrl_probe(struct platform_device *pdev)
		return 0;
		}

		static int byt_pinctrl_remove(struct platform_device *pdev)
		{
		struct byt_gpio *vg = platform_get_drvdata(pdev);

		pm_runtime_disable(&pdev->dev);
		gpiochip_remove(&vg->chip);
		pinctrl_unregister(vg->pctl_dev);

		return 0;
		}

		#ifdef CONFIG_PM_SLEEP
		static int byt_gpio_suspend(struct device *dev)
		{
		@@ -1930,10 +1918,11 @@ static const struct dev_pm_ops byt_gpio_pm_ops = {

		static struct platform_driver byt_gpio_driver = {
		.probe = byt_pinctrl_probe,
		.remove = byt_pinctrl_remove,
		.driver = {
		.name = "byt_gpio",
		.pm = &byt_gpio_pm_ops,
		.suppress_bind_attrs = true,

		.acpi_match_table = ACPI_PTR(byt_gpio_acpi_match),
		},
		};
		@@ -1943,9 +1932,3 @@ static int __init byt_gpio_init(void)
		return platform_driver_register(&byt_gpio_driver);
		}
		subsys_initcall(byt_gpio_init);

		static void __exit byt_gpio_exit(void)
		{
		platform_driver_unregister(&byt_gpio_driver);
		}
		module_exit(byt_gpio_exit);