Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 359d7d1c authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: update_changeattr does not need to set NFS_INO_REVAL_PAGECACHE 



We're already invalidating the data cache, and setting the new change
attribute. Since directories don't care about the i_size field, there
is no need to be forcing any extra revalidation of the page cache.

We do keep the NFS_INO_INVALID_ATTR flag, in order to force an
attribute cache revalidation on stat() calls since we do not
update the mtime and ctime fields.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent f2c1b510

fs/nfs/nfs4proc.c

+1 −1
Original line number Diff line number Diff line
@@ -774,7 +774,7 @@ static void update_changeattr(struct inode *dir, struct nfs4_change_info *cinfo) 
	struct nfs_inode *nfsi = NFS_I(dir);



	spin_lock(&dir->i_lock);

	nfsi->cache_validity |= NFS_INO_INVALID_ATTR|NFS_INO_REVAL_PAGECACHE|NFS_INO_INVALID_DATA;

	nfsi->cache_validity |= NFS_INO_INVALID_ATTR|NFS_INO_INVALID_DATA;

	if (!cinfo->atomic || cinfo->before != dir->i_version)

		nfs_force_lookup_revalidate(dir);

	dir->i_version = cinfo->after;