Commit 3594f4c0 authored Jun 06, 2013 by Kees Cook Committed by Anton Vorontsov Jun 06, 2013

charger-manager: Ensure event is not used as format string

The exposed interface for cm_notify_event() could result in the event msg
string being parsed as a format string. Make sure it is only used as a
literal string.

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Cc: Anton Vorontsov <cbou@mail.ru>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>

parent 4b43eb67

drivers/power/charger-manager.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -450,7 +450,7 @@ static void uevent_notify(struct charger_manager cm, const char event)
	strncpy(env_str, event, UEVENT_BUF_SIZE);		strncpy(env_str, event, UEVENT_BUF_SIZE);
	kobject_uevent(&cm->dev->kobj, KOBJ_CHANGE);		kobject_uevent(&cm->dev->kobj, KOBJ_CHANGE);

	dev_info(cm->dev, event);		dev_info(cm->dev, "%s", event);
	}		}

	/**		/**