Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 352051ef authored by Douglas Anderson's avatar Douglas Anderson Committed by Ulf Hansson
Browse files

phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_on/off() 



There's no reason to store the return value of rockchip_emmc_phy_power()
in a variable nor to check it.  Just return it.

Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Acked-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Reviewed-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 11075456

drivers/phy/phy-rockchip-emmc.c

+2 −12
Original line number Diff line number Diff line
@@ -169,20 +169,14 @@ static int rockchip_emmc_phy_power(struct rockchip_emmc_phy *rk_phy, 
static int rockchip_emmc_phy_power_off(struct phy *phy)

{

	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);

	int ret = 0;



	/* Power down emmc phy analog blocks */

	ret = rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_OFF);

	if (ret)

		return ret;



	return 0;

	return rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_OFF);

}



static int rockchip_emmc_phy_power_on(struct phy *phy)

{

	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);

	int ret = 0;



	/* DLL operation: 200 MHz */

	regmap_write(rk_phy->reg_base,
@@ -213,11 +207,7 @@ static int rockchip_emmc_phy_power_on(struct phy *phy) 
				   PHYCTRL_OTAPDLYSEL_SHIFT));



	/* Power up emmc phy analog blocks */

	ret = rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_ON);

	if (ret)

		return ret;



	return 0;

	return rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_ON);

}



static const struct phy_ops ops = {