Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34e49d4f authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

fs/proc/base.c, kernel/latencytop.c: convert sprintf_symbol() to %ps 



Use temporary lr for struct latency_record for improved readability and
fewer columns used.  Removed trailing space from output.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1bdcd78e

fs/proc/base.c

+8 −14
Original line number Diff line number Diff line
@@ -373,24 +373,18 @@ static int lstats_show_proc(struct seq_file *m, void *v) 
		return -ESRCH;

	seq_puts(m, "Latency Top version : v0.1\n");

	for (i = 0; i < 32; i++) {

		if (task->latency_record[i].backtrace[0]) {

		struct latency_record *lr = &task->latency_record[i];

		if (lr->backtrace[0]) {

			int q;

			seq_printf(m, "%i %li %li",

				task->latency_record[i].count,

				task->latency_record[i].time,

				task->latency_record[i].max);

				   lr->count, lr->time, lr->max);

			for (q = 0; q < LT_BACKTRACEDEPTH; q++) {

				char sym[KSYM_SYMBOL_LEN];

				char *c;

				if (!task->latency_record[i].backtrace[q])

				unsigned long bt = lr->backtrace[q];

				if (!bt)

					break;

				if (task->latency_record[i].backtrace[q] == ULONG_MAX)

				if (bt == ULONG_MAX)

					break;

				sprint_symbol(sym, task->latency_record[i].backtrace[q]);

				c = strchr(sym, '+');

				if (c)

					*c = 0;

				seq_printf(m, "%s ", sym);

				seq_printf(m, " %ps", (void *)bt);

			}

			seq_printf(m, "\n");

		}

kernel/latencytop.c

+9 −14
Original line number Diff line number Diff line
@@ -241,24 +241,19 @@ static int lstats_show(struct seq_file *m, void *v) 
	seq_puts(m, "Latency Top version : v0.1\n");



	for (i = 0; i < MAXLR; i++) {

		if (latency_record[i].backtrace[0]) {

		struct latency_record *lr = &latency_record[i];



		if (lr->backtrace[0]) {

			int q;

			seq_printf(m, "%i %lu %lu",

				latency_record[i].count,

				latency_record[i].time,

				latency_record[i].max);

				   lr->count, lr->time, lr->max);

			for (q = 0; q < LT_BACKTRACEDEPTH; q++) {

				char sym[KSYM_SYMBOL_LEN];

				char *c;

				if (!latency_record[i].backtrace[q])

				unsigned long bt = lr->backtrace[q];

				if (!bt)

					break;

				if (latency_record[i].backtrace[q] == ULONG_MAX)

				if (bt == ULONG_MAX)

					break;

				sprint_symbol(sym, latency_record[i].backtrace[q]);

				c = strchr(sym, '+');

				if (c)

					*c = 0;

				seq_printf(m, "%s ", sym);

				seq_printf(m, " %ps", (void *)bt);

			}

			seq_printf(m, "\n");

		}