Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34c7b3ac authored by Julia Lawall's avatar Julia Lawall Committed by Alexandre Belloni
Browse files

rtc: constify rtc_class_ops structures 

Check for rtc_class_ops structures that are only passed to
devm_rtc_device_register, rtc_device_register,
platform_device_register_data, all of which declare the corresponding
parameter as const.  Declare rtc_class_ops structures that have these
properties as const.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct rtc_class_ops i@p = { ... };

@ok@
identifier r.i;
expression e1,e2,e3,e4;
position p;
@@
(
devm_rtc_device_register(e1,e2,&i@p,e3)
|
rtc_device_register(e1,e2,&i@p,e3)
|
platform_device_register_data(e1,e2,e3,&i@p,e4)
)

@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct rtc_class_ops i = { ... };
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarBaruch Siach <baruch@tkos.co.il>
Acked-by: default avatarHans Ulli Kroll <ulli.kroll@googlemail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarThierry Reding <treding@nvidia.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 637cac7c

drivers/rtc/rtc-at32ap700x.c

+1 −1
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ static irqreturn_t at32_rtc_interrupt(int irq, void *dev_id) 
	return ret;

}



static struct rtc_class_ops at32_rtc_ops = {

static const struct rtc_class_ops at32_rtc_ops = {

	.read_time	= at32_rtc_readtime,

	.set_time	= at32_rtc_settime,

	.read_alarm	= at32_rtc_readalarm,

drivers/rtc/rtc-coh901331.c

+1 −1
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ static int coh901331_alarm_irq_enable(struct device *dev, unsigned int enabled) 
	return 0;

}



static struct rtc_class_ops coh901331_ops = {

static const struct rtc_class_ops coh901331_ops = {

	.read_time = coh901331_read_time,

	.set_mmss = coh901331_set_mmss,

	.read_alarm = coh901331_read_alarm,

drivers/rtc/rtc-davinci.c

+1 −1
Original line number Diff line number Diff line
@@ -469,7 +469,7 @@ static int davinci_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) 
	return 0;

}



static struct rtc_class_ops davinci_rtc_ops = {

static const struct rtc_class_ops davinci_rtc_ops = {

	.ioctl			= davinci_rtc_ioctl,

	.read_time		= davinci_rtc_read_time,

	.set_time		= davinci_rtc_set_time,

drivers/rtc/rtc-digicolor.c

+1 −1
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ static int dc_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) 
	return 0;

}



static struct rtc_class_ops dc_rtc_ops = {

static const struct rtc_class_ops dc_rtc_ops = {

	.read_time		= dc_rtc_read_time,

	.set_mmss		= dc_rtc_set_mmss,

	.read_alarm		= dc_rtc_read_alarm,

drivers/rtc/rtc-ds1302.c

+1 −1
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ static int ds1302_rtc_get_time(struct device *dev, struct rtc_time *time) 
	return rtc_valid_tm(time);

}



static struct rtc_class_ops ds1302_rtc_ops = {

static const struct rtc_class_ops ds1302_rtc_ops = {

	.read_time	= ds1302_rtc_get_time,

	.set_time	= ds1302_rtc_set_time,

};