Commit 348f7d4a authored Feb 05, 2014 by andrea.merello Committed by John W. Linville Feb 06, 2014

rtl8180: Add error check for pci_map_single return value in TX path



Orignal code will not detect a DMA mapping failure, causing the HW
to attempt a DMA from an invalid address.

This patch add the error check and eventually simply drops the TX
packet if we can't map it for DMA.

Signed-off-by: andrea merello <andrea.merello@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 2b4db05e

drivers/net/wireless/rtl818x/rtl8180/dev.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -276,6 +276,13 @@ static void rtl8180_tx(struct ieee80211_hw *dev,
		mapping = pci_map_single(priv->pdev, skb->data,
		skb->len, PCI_DMA_TODEVICE);

		if (pci_dma_mapping_error(priv->pdev, mapping)) {
		kfree_skb(skb);
		dev_err(&priv->pdev->dev, "TX DMA mapping error\n");
		return;

		}

		tx_flags = RTL818X_TX_DESC_FLAG_OWN \| RTL818X_TX_DESC_FLAG_FS \|
		RTL818X_TX_DESC_FLAG_LS \|
		(ieee80211_get_tx_rate(dev, info)->hw_value << 24) \|