Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3474cb3c authored by Joe Perches's avatar Joe Perches Committed by Grant Likely
Browse files

gpio: Convert gpio_is_valid to return bool 



Make the code a bit more readable.

Instead of casting an int to an unsigned then comparing to
MAX_NR_GPIOS, add a >= 0 test and let the compiler optimizer
do the conversion to unsigned.

The generated code should be the same.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
parent 82ab0f75

include/asm-generic/gpio.h

+3 −3
Original line number Diff line number Diff line
@@ -35,9 +35,9 @@ 
 * platform data and other tables.

 */



static inline int gpio_is_valid(int number)

static inline bool gpio_is_valid(int number)

{

	return ((unsigned)number) < ARCH_NR_GPIOS;

	return number >= 0 && number < ARCH_NR_GPIOS;

}



struct device;
@@ -212,7 +212,7 @@ extern void gpio_unexport(unsigned gpio); 


#else	/* !CONFIG_GPIOLIB */



static inline int gpio_is_valid(int number)

static inline bool gpio_is_valid(int number)

{

	/* only non-negative numbers are valid */

	return number >= 0;

include/linux/gpio.h

+2 −2
Original line number Diff line number Diff line
@@ -25,9 +25,9 @@ struct gpio_chip; 
 * warning when something is wrongly called.

 */



static inline int gpio_is_valid(int number)

static inline bool gpio_is_valid(int number)

{

	return 0;

	return false;

}



static inline int gpio_request(unsigned gpio, const char *label)