Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 341ef565 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mauro Carvalho Chehab
Browse files

[media] lm3560: prevent memory leak in case of pdata absence 



If we have no pdata defined and driver fails to register we leak memory.
Converting to devm_kzalloc prevents this to happen.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent d1166b0f

drivers/media/i2c/lm3560.c

+1 −2
Original line number Diff line number Diff line
@@ -416,8 +416,7 @@ static int lm3560_probe(struct i2c_client *client, 


	/* if there is no platform data, use chip default value */

	if (pdata == NULL) {

		pdata =

		    kzalloc(sizeof(struct lm3560_platform_data), GFP_KERNEL);

		pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);

		if (pdata == NULL)

			return -ENODEV;

		pdata->peak = LM3560_PEAK_3600mA;