Commit 328bd899 authored Nov 24, 2008 by Patrick McHardy

netfilter: nf_conntrack_proto_sctp: avoid bogus warning

net/netfilter/nf_conntrack_proto_sctp.c: In function 'sctp_packet':
net/netfilter/nf_conntrack_proto_sctp.c:376: warning: array subscript is above array bounds

gcc doesn't realize that do_basic_checks() guarantees that there is
at least one valid chunk and thus new_state is never SCTP_CONNTRACK_MAX
after the loop. Initialize to SCTP_CONNTRACK_NONE to avoid the warning.

Based on patch by Wu Fengguang <wfg@linux.intel.com>

Signed-off-by: Patrick McHardy <kaber@trash.net>

parent 018a7bf1

net/netfilter/nf_conntrack_proto_sctp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -317,7 +317,7 @@ static int sctp_packet(struct nf_conn *ct,
		goto out;
		}

		old_state = new_state = SCTP_CONNTRACK_MAX;
		old_state = new_state = SCTP_CONNTRACK_NONE;
		write_lock_bh(&sctp_lock);
		for_each_sctp_chunk (skb, sch, _sch, offset, dataoff, count) {
		/* Special cases of Verification tag check (Sec 8.5.1) */