Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3189e490 authored by Dan Carpenter's avatar Dan Carpenter Committed by Joerg Roedel
Browse files

iommu/mediatek: Check for NULL instead of IS_ERR() 



of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: 0df4fabe ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 0b6c0ad3

drivers/iommu/mtk_iommu.c

+3 −3
Original line number Diff line number Diff line
@@ -627,7 +627,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) 
			plarbdev = of_platform_device_create(

						larbnode, NULL,

						platform_bus_type.dev_root);

			if (IS_ERR(plarbdev))

			if (!plarbdev)

				return -EPROBE_DEFER;

		}

		data->smi_imu.larb_imu[i].dev = &plarbdev->dev;
@@ -720,8 +720,8 @@ static int mtk_iommu_init_fn(struct device_node *np) 
	struct platform_device *pdev;



	pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);

	if (IS_ERR(pdev))

		return PTR_ERR(pdev);

	if (!pdev)

		return -ENOMEM;



	ret = platform_driver_register(&mtk_iommu_driver);

	if (ret) {