Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30a39153 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Rafael J. Wysocki
Browse files

cpufreq: intel_pstate: fix inconsistency in setting policy limits 



When user sets performance policy using cpufreq interface, it is possible
that because of policy->max limits, the actual performance is still
limited. But the current implementation will silently switch the
policy to powersave and start using powersave limits. If user modifies
any limits using intel_pstate sysfs, this is actually changing powersave
limits.

The current implementation tracks limits under powersave and performance
policy using two different variables. When policy->max is less than
policy->cpuinfo.max_freq, only powersave limit variable is used.

This fix causes the performance limits variable to be used always when
the policy is performance.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent febce40f

drivers/cpufreq/intel_pstate.c

+23 −6
Original line number Diff line number Diff line
@@ -1141,6 +1141,20 @@ static void intel_pstate_clear_update_util_hook(unsigned int cpu) 
	synchronize_sched();

}



static void intel_pstate_set_performance_limits(struct perf_limits *limits)

{

	limits->no_turbo = 0;

	limits->turbo_disabled = 0;

	limits->max_perf_pct = 100;

	limits->max_perf = int_tofp(1);

	limits->min_perf_pct = 100;

	limits->min_perf = int_tofp(1);

	limits->max_policy_pct = 100;

	limits->max_sysfs_pct = 100;

	limits->min_policy_pct = 0;

	limits->min_sysfs_pct = 0;

}



static int intel_pstate_set_policy(struct cpufreq_policy *policy)

{

	if (!policy->cpuinfo.max_freq)
@@ -1148,15 +1162,18 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy) 


	intel_pstate_clear_update_util_hook(policy->cpu);



	if (policy->policy == CPUFREQ_POLICY_PERFORMANCE &&

	    policy->max >= policy->cpuinfo.max_freq) {

		pr_debug("intel_pstate: set performance\n");

	if (policy->policy == CPUFREQ_POLICY_PERFORMANCE) {

		limits = &performance_limits;

		if (policy->max >= policy->cpuinfo.max_freq) {

			pr_debug("intel_pstate: set performance\n");

			intel_pstate_set_performance_limits(limits);

			goto out;

		}



	} else {

		pr_debug("intel_pstate: set powersave\n");

		limits = &powersave_limits;

	}



	limits->min_policy_pct = (policy->min * 100) / policy->cpuinfo.max_freq;

	limits->min_policy_pct = clamp_t(int, limits->min_policy_pct, 0 , 100);

	limits->max_policy_pct = DIV_ROUND_UP(policy->max * 100,