Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 302b4644 authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

i40e: (ptp) warn when PF_ID does not match in PRTTSYN_CTL0 



Display a verbose warning message when the incorrect PF attempts to
control timestamping for a port to which it was not assigned. This
shouldn't display except in the case of multiple PFs per port. The
primary intent of this message is to help debugging the reason why the
SIOCSHWTSTAMP ioctl has failed, and to help narrow the cause of the
issue.

Change-ID: Ic98798e0c844d98389d4c20e7160ba256f2bc7e8
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent ec9a7db7

drivers/net/ethernet/intel/i40e/i40e_ptp.c

+6 −2
Original line number Diff line number Diff line
@@ -447,8 +447,12 @@ static int i40e_ptp_set_timestamp_mode(struct i40e_pf *pf, 
	/* Confirm that 1588 is supported on this PF. */

	pf_id = (rd32(hw, I40E_PRTTSYN_CTL0) & I40E_PRTTSYN_CTL0_PF_ID_MASK) >>

		I40E_PRTTSYN_CTL0_PF_ID_SHIFT;

	if (hw->pf_id != pf_id)

		return -EINVAL;

	if (hw->pf_id != pf_id) {

		dev_err(&pf->pdev->dev,

			"PF %d attempted to control timestamp mode on port %d, which is owned by PF %d\n",

			hw->pf_id, hw->port, pf_id);

		return -EPERM;

	}



	switch (config->tx_type) {

	case HWTSTAMP_TX_OFF: