Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fbe74b9 authored by Roel Kluin's avatar Roel Kluin Committed by Takashi Iwai
Browse files

sound/oss/pss: Fix test of unsigned in pss_reset_dsp() and pss_download_boot() 



limit and jiffies are unsigned so the test did not work.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 718deb6b

sound/oss/pss.c

+3 −3
Original line number Diff line number Diff line
@@ -269,7 +269,7 @@ static int pss_reset_dsp(pss_confdata * devc) 
	unsigned long   i, limit = jiffies + HZ/10;



	outw(0x2000, REG(PSS_CONTROL));

	for (i = 0; i < 32768 && (limit-jiffies >= 0); i++)

	for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++)

		inw(REG(PSS_CONTROL));

	outw(0x0000, REG(PSS_CONTROL));

	return 1;
@@ -369,11 +369,11 @@ static int pss_download_boot(pss_confdata * devc, unsigned char *block, int size 
		outw(0, REG(PSS_DATA));



		limit = jiffies + HZ/10;

		for (i = 0; i < 32768 && (limit - jiffies >= 0); i++)

		for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++)

			val = inw(REG(PSS_STATUS));



		limit = jiffies + HZ/10;

		for (i = 0; i < 32768 && (limit-jiffies >= 0); i++)

		for (i = 0; i < 32768 && time_after_eq(limit, jiffies); i++)

		{

			val = inw(REG(PSS_STATUS));

			if (val & 0x4000)