Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f5d1f79 authored by Mahesh Rajashekhara's avatar Mahesh Rajashekhara Committed by James Bottomley
Browse files

aacraid: IOCTL pass-through command fix 



The Linux aacriad driver fails to detect the case of SG list count=0 on IOCTL
pass-through command and cause intermittent fault.  The result is the Linux
aacriad driver send down IOCTL pass-through command with one not initialized
SG list to firmware when receiving SG list count =0 on pass-through command.

Signed-off-by: default avatarMahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarMurthy Bhat <Murthy.Bhat@pmcs.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent 46154a02

drivers/scsi/aacraid/commctrl.c

+8 −2
Original line number Diff line number Diff line
@@ -689,7 +689,10 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) 
			kfree (usg);

		}

		srbcmd->count = cpu_to_le32(byte_count);

		if (user_srbcmd->sg.count)

			psg->count = cpu_to_le32(sg_indx+1);

		else

			psg->count = 0;

		status = aac_fib_send(ScsiPortCommand64, srbfib, actual_fibsize, FsaNormal, 1, 1,NULL,NULL);

	} else {

		struct user_sgmap* upsg = &user_srbcmd->sg;
@@ -775,7 +778,10 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) 
			}

		}

		srbcmd->count = cpu_to_le32(byte_count);

		if (user_srbcmd->sg.count)

			psg->count = cpu_to_le32(sg_indx+1);

		else

			psg->count = 0;

		status = aac_fib_send(ScsiPortCommand, srbfib, actual_fibsize, FsaNormal, 1, 1, NULL, NULL);

	}

	if (status == -ERESTARTSYS) {