Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f51bf4b authored by Zhen Lei's avatar Zhen Lei Committed by Alex Williamson
Browse files

vfio: put off the allocation of "minor" in vfio_create_group 



The next code fragment "list_for_each_entry" is not depend on "minor". With this
patch, the free of "minor" in "list_for_each_entry" can be reduced, and there is
no functional change.

Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent a7fa7c77

drivers/vfio/vfio.c

+6 −7
Original line number Diff line number Diff line
@@ -234,22 +234,21 @@ static struct vfio_group *vfio_create_group(struct iommu_group *iommu_group) 


	mutex_lock(&vfio.group_lock);



	minor = vfio_alloc_group_minor(group);

	if (minor < 0) {

		vfio_group_unlock_and_free(group);

		return ERR_PTR(minor);

	}



	/* Did we race creating this group? */

	list_for_each_entry(tmp, &vfio.group_list, vfio_next) {

		if (tmp->iommu_group == iommu_group) {

			vfio_group_get(tmp);

			vfio_free_group_minor(minor);

			vfio_group_unlock_and_free(group);

			return tmp;

		}

	}



	minor = vfio_alloc_group_minor(group);

	if (minor < 0) {

		vfio_group_unlock_and_free(group);

		return ERR_PTR(minor);

	}



	dev = device_create(vfio.class, NULL,

			    MKDEV(MAJOR(vfio.group_devt), minor),

			    group, "%d", iommu_group_id(iommu_group));