Commit 2f432823 authored Apr 30, 2011 by Nicolas Ferre Committed by Vinod Koul May 02, 2011

dmaengine: at_hdmac: remove channel status testing in tasklet



There is no need to test if channel is enabled in tasklet:
- in error path, channel is disabled in interrupt routine
- in normal path, this test is performed in sub functions to report
a misuse of the engine.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent cc52a10a

drivers/dma/at_hdmac.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -472,13 +472,6 @@ static void atc_tasklet(unsigned long data)
		{
		struct at_dma_chan atchan = (struct at_dma_chan )data;

		/* Channel cannot be enabled here */
		if (atc_chan_is_enabled(atchan)) {
		dev_err(chan2dev(&atchan->chan_common),
		"BUG: channel enabled in tasklet\n");
		return;
		}

		spin_lock(&atchan->lock);
		if (test_and_clear_bit(ATC_IS_ERROR, &atchan->status))
		atc_handle_error(atchan);