Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f1e93f8 authored by Jianqun's avatar Jianqun Committed by Mark Brown
Browse files

ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller 



Reference rockchip I2S controller TRM, modify some registers' property
I2S_FIFOLR: read / write, but not volatile, not precious
I2S_INTSR: read / write
I2S_CLR: volatile, register value will be cleared by read

Test on RK3288 with max98090.

Signed-off-by: default avatarJianqun Xu <jay.xu@rock-chips.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 07833d88

sound/soc/rockchip/rockchip_i2s.c

+3 −3
Original line number Diff line number Diff line
@@ -362,6 +362,8 @@ static bool rockchip_i2s_rd_reg(struct device *dev, unsigned int reg) 
	case I2S_XFER:

	case I2S_CLR:

	case I2S_RXDR:

	case I2S_FIFOLR:

	case I2S_INTSR:

		return true;

	default:

		return false;
@@ -371,8 +373,8 @@ static bool rockchip_i2s_rd_reg(struct device *dev, unsigned int reg) 
static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg)

{

	switch (reg) {

	case I2S_FIFOLR:

	case I2S_INTSR:

	case I2S_CLR:

		return true;

	default:

		return false;
@@ -382,8 +384,6 @@ static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg) 
static bool rockchip_i2s_precious_reg(struct device *dev, unsigned int reg)

{

	switch (reg) {

	case I2S_FIFOLR:

		return true;

	default:

		return false;

	}