Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2eab9b1a authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: ioatdma: fix uninitialized array usage 



Static analysis showed that unitialized array is being used for compare.
At line 850 when a dma_mapping_error() occurs, it jumps to dma_unmap. At
this point, dma_srcs has not been initialized. However, the code after
dma_unmap label checks dma_srcs for a comparison and thus is comparing
to random garbage in the array. Given that when dest_dma is being mapped
this is the first instance of mapping DMA memory and failed, there is
really nothing to be cleaned up and thus should jump to free_resources
label instead.

Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 29b4817d

drivers/dma/ioat/init.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -828,7 +828,7 @@ static int ioat_xor_val_self_test(struct ioatdma_device *ioat_dma) 




	dest_dma = dma_map_page(dev, dest, 0, PAGE_SIZE, DMA_FROM_DEVICE);

	dest_dma = dma_map_page(dev, dest, 0, PAGE_SIZE, DMA_FROM_DEVICE);

	if (dma_mapping_error(dev, dest_dma))

	if (dma_mapping_error(dev, dest_dma))

		goto dma_unmap;

		goto free_resources;





	for (i = 0; i < IOAT_NUM_SRC_TEST; i++)

	for (i = 0; i < IOAT_NUM_SRC_TEST; i++)

		dma_srcs[i] = DMA_ERROR_CODE;

		dma_srcs[i] = DMA_ERROR_CODE;