Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2dfbe9af authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: zx: spdif: Fix devm_ioremap_resource return value check 



Value returned by devm_ioremap_resource() was checked for non-NULL but
devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of
error this could lead to dereference of ERR_PTR.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski.k@gmail.com>
Reviewed-by: default avatarJun Nie <jun.nie@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a18da49f

sound/soc/zte/zx296702-spdif.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -322,9 +322,9 @@ static int zx_spdif_probe(struct platform_device *pdev) 
	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	zx_spdif->mapbase = res->start;

	zx_spdif->mapbase = res->start;

	zx_spdif->reg_base = devm_ioremap_resource(&pdev->dev, res);

	zx_spdif->reg_base = devm_ioremap_resource(&pdev->dev, res);

	if (!zx_spdif->reg_base) {

	if (IS_ERR(zx_spdif->reg_base)) {

		dev_err(&pdev->dev, "ioremap failed!\n");

		dev_err(&pdev->dev, "ioremap failed!\n");

		return -EIO;

		return PTR_ERR(zx_spdif->reg_base);

	}

	}





	zx_spdif_dev_init(zx_spdif->reg_base);

	zx_spdif_dev_init(zx_spdif->reg_base);