Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ddf6cd6 authored by Daniel Krueger's avatar Daniel Krueger Committed by Linus Walleij
Browse files

pch_gpio: set value before enabling output direction 



This ensures that the output signal does not toggle if set to high.

Signed-off-by: default avatarDaniel Krueger <daniel.krueger@systec-electronic.com>
Signed-off-by: default avatarAlexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent fc860356

drivers/gpio/gpio-pch.c

+5 −3
Original line number Diff line number Diff line
@@ -138,9 +138,6 @@ static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, 
	unsigned long flags;



	spin_lock_irqsave(&chip->spinlock, flags);

	pm = ioread32(&chip->reg->pm) & ((1 << gpio_pins[chip->ioh]) - 1);

	pm |= (1 << nr);

	iowrite32(pm, &chip->reg->pm);



	reg_val = ioread32(&chip->reg->po);

	if (val)
@@ -148,6 +145,11 @@ static int pch_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, 
	else

		reg_val &= ~(1 << nr);

	iowrite32(reg_val, &chip->reg->po);



	pm = ioread32(&chip->reg->pm) & ((1 << gpio_pins[chip->ioh]) - 1);

	pm |= (1 << nr);

	iowrite32(pm, &chip->reg->pm);



	spin_unlock_irqrestore(&chip->spinlock, flags);



	return 0;