Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d73b069 authored by Peter Hurley's avatar Peter Hurley Committed by Greg Kroah-Hartman
Browse files

staging: dgap: Remove redundant write_wait wakeups 



Waking the write_wait queue is exactly what tty_wakeup() does;
remove the open-coded wakeups.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 02f14c79

drivers/staging/dgap/dgap.c

+0 −6
Original line number Diff line number Diff line
@@ -3155,8 +3155,6 @@ static void dgap_tty_flush_buffer(struct tty_struct *tty) 


	spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);

	spin_unlock_irqrestore(&bd->bd_lock, lock_flags);

	if (waitqueue_active(&tty->write_wait))

		wake_up_interruptible(&tty->write_wait);

	tty_wakeup(tty);

}
@@ -4953,10 +4951,6 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd, 
			ch->ch_pun.un_flags &= ~(UN_LOW | UN_EMPTY);

			wake_up_interruptible(&ch->ch_pun.un_flags_wait);

		}

		if (waitqueue_active(&tty->write_wait))

			wake_up_interruptible(&tty->write_wait);



		/* Can't hold any locks when calling tty_wakeup! */

		spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);

		spin_unlock_irqrestore(&bd->bd_lock, lock_flags);

		tty_wakeup(tty);