Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2cdf25bb authored by George Cherian's avatar George Cherian Committed by Wim Van Sebroeck
Browse files

watchdog: shwdt: Remove the unnecessary check of resource after platform_get_resource() 



devm_ioremap_resource check for a valid resource. Remove the unnecessary check.
Also group platform_get_resource and devm_ioremap_resource together for better
readability.

Signed-off-by: default avatarGeorge Cherian <george.cherian@ti.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 37f15291

drivers/watchdog/shwdt.c

+1 −4
Original line number Diff line number Diff line
@@ -230,10 +230,6 @@ static int sh_wdt_probe(struct platform_device *pdev) 
	if (pdev->id != -1)

		return -EINVAL;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (unlikely(!res))

		return -EINVAL;



	wdt = devm_kzalloc(&pdev->dev, sizeof(struct sh_wdt), GFP_KERNEL);

	if (unlikely(!wdt))

		return -ENOMEM;
@@ -249,6 +245,7 @@ static int sh_wdt_probe(struct platform_device *pdev) 
		wdt->clk = NULL;

	}



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	wdt->base = devm_ioremap_resource(wdt->dev, res);

	if (IS_ERR(wdt->base))

		return PTR_ERR(wdt->base);