Commit 2bdf6ea5 authored Apr 27, 2016 by Krzysztof Opasiak Committed by Greg Kroah-Hartman Apr 28, 2016

usb: usbip: vudc: Fix WARN_ON() usage pattern



Fix WARN_ON() macro usage as suggested by Felipe.
Instead of using:
if (cond) {
   WARN_ON(1);
   do_stuff();
}

Use a better pattern with WARN_ON() placed in if condition:

if (WARN_ON(cond))
   do_stuff();

Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f945c546

drivers/usb/usbip/vudc_dev.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -312,10 +312,9 @@ static void vep_free_request(struct usb_ep _ep, struct usb_request _req)
		{
		struct vrequest *req;

		if (!_ep \|\| !_req) {
		WARN_ON(1);
		if (WARN_ON(!_ep \|\| !_req))
		return;
		}

		req = to_vrequest(_req);
		kfree(req);
		}