Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b8b28fd authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu
Browse files

crypto: keywrap - memzero the correct memory 



We're clearing the wrong memory.  The memory corruption is likely
harmless because we weren't going to use that stack memory again but not
zeroing is a potential information leak.

Fixes: e28facde ('crypto: keywrap - add key wrapping block chaining mode')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarStephan Mueller <smueller@chronox.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d1662165

crypto/keywrap.c

+2 −2
Original line number Diff line number Diff line
@@ -212,7 +212,7 @@ static int crypto_kw_decrypt(struct blkcipher_desc *desc, 
			  SEMIBSIZE))

		ret = -EBADMSG;



	memzero_explicit(&block, sizeof(struct crypto_kw_block));

	memzero_explicit(block, sizeof(struct crypto_kw_block));



	return ret;

}
@@ -297,7 +297,7 @@ static int crypto_kw_encrypt(struct blkcipher_desc *desc, 
	/* establish the IV for the caller to pick up */

	memcpy(desc->info, block->A, SEMIBSIZE);



	memzero_explicit(&block, sizeof(struct crypto_kw_block));

	memzero_explicit(block, sizeof(struct crypto_kw_block));



	return 0;

}