Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b3c543a authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB: drivers/media/video/tlg2300: Use kmemdup 

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDouglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 1ece3609

drivers/media/video/tlg2300/pd-main.c

+1 −2
Original line number Diff line number Diff line
@@ -227,12 +227,11 @@ static int firmware_download(struct usb_device *udev) 


	fwlength = fw->size;



	fwbuf = kzalloc(fwlength, GFP_KERNEL);

	fwbuf = kmemdup(fw->data, fwlength, GFP_KERNEL);

	if (!fwbuf) {

		ret = -ENOMEM;

		goto out;

	}

	memcpy(fwbuf, fw->data, fwlength);



	max_packet_size = udev->ep_out[0x1]->desc.wMaxPacketSize;

	log("\t\t download size : %d", (int)max_packet_size);