Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a54cf76 authored by Robert Hancock's avatar Robert Hancock Committed by Jeff Garzik
Browse files

sata_nv: complain on spurious completion notifiers 



Recently Tejun wrote a patch to ahci.c to make it raise a HSM violation
if the drive attempted to complete a tag that wasn't outstanding. We could
run into the same problem with sata_nv ADMA. This adds code to raise a HSM
violation error if the controller gives us a notifier tag that isn't
outstanding, since the drive may be issuing spurious completions.

Signed-off-by: default avatarRobert Hancock <hancockr@shaw.ca>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 32d90911

drivers/ata/sata_nv.c

+11 −0
Original line number Original line Diff line number Diff line
@@ -740,6 +740,17 @@ static int nv_adma_check_cpb(struct ata_port *ap, int cpb_num, int force_err) 
			DPRINTK("Completing qc from tag %d with err_mask %u\n",cpb_num,

			DPRINTK("Completing qc from tag %d with err_mask %u\n",cpb_num,

				qc->err_mask);

				qc->err_mask);

			ata_qc_complete(qc);

			ata_qc_complete(qc);

		} else {

			struct ata_eh_info *ehi = &ap->eh_info;

			/* Notifier bits set without a command may indicate the drive

			   is misbehaving. Raise host state machine violation on this

			   condition. */

			ata_port_printk(ap, KERN_ERR, "notifier for tag %d with no command?\n",

				cpb_num);

			ehi->err_mask |= AC_ERR_HSM;

			ehi->action |= ATA_EH_SOFTRESET;

			ata_port_freeze(ap);

			return 1;

		}

		}

	}

	}

	return 0;

	return 0;