Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29816d9a authored by Stephen Hemminger's avatar Stephen Hemminger Committed by Jeff Garzik
Browse files

skge: FIFO Ram calculation error 



The calculation of usable FIFO RAM is wrong in the skge driver.
First, is doesn't take into account the reserved area on the original
SysKonnect Genesis boards. Second it has an off-by-one error because
hw->ports is either 1 or 2.

Signed-off-by: default avatarStephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 1c147885

drivers/net/skge.c

+2 −2
Original line number Diff line number Diff line
@@ -2619,8 +2619,8 @@ static int skge_up(struct net_device *dev) 
		yukon_mac_init(hw, port);

	spin_unlock_bh(&hw->phy_lock);



	/* Configure RAMbuffers */

	chunk = hw->ram_size / ((hw->ports + 1)*2);

	/* Configure RAMbuffers - equally between ports and tx/rx */

	chunk = (hw->ram_size  - hw->ram_offset) / (hw->ports * 2);

	ram_addr = hw->ram_offset + 2 * chunk * port;



	skge_ramset(hw, rxqaddr[port], ram_addr, chunk);